test: cover drift-comment permissions and promote selective/force emission#370
Open
joshua-temple wants to merge 1 commit into
Open
test: cover drift-comment permissions and promote selective/force emission#370joshua-temple wants to merge 1 commit into
joshua-temple wants to merge 1 commit into
Conversation
This was referenced Jun 26, 2026
…ssion Closes the literal coverage gaps in #317, #326, and the unasserted promote emissions in #325. Adds an e2e assertion that the generated drift-comment workflow carries permissions {} (least privilege), and a generator unit test asserting promote threads the deploys filter and the force flag through to the workflow. The CLI deploys filter and the #325 runtime side-effects were already covered at unit or act-plus-gitea; live remains the documented ceiling. Signed-off-by: Joshua Temple <[email protected]>
joshua-temple
force-pushed
the
test/close-coverage-gaps
branch
from
efe1e26 to
65535ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the literal coverage gaps behind #317 and #326 and the unasserted promote emissions in #325. Adds (1) an e2e assertion in 28-drift-check that the generated drift-comment workflow carries
permissions: {}, and (2) a generator unit test asserting promote threads the--deploysfilter and the--forceflag into the emitted workflow. The CLI deploys filter and the #325 runtime side-effects were already covered hermetically. go build/test/lint clean.