add cancel all button to dashboard by MattShirley · Pull Request #1455 · ssl-hep/ServiceX

MattShirley · 2026-05-21T19:27:48Z

Adds Cancel All button to the Dashboard when ENABLE_AUTH=True. This will cancel all active transformations based upon the existing individual Cancel logic.

When ENABLE_AUTH=False, the button is not present and the route returns 400.

for more information, see https://pre-commit.ci

codecov · 2026-05-21T19:29:56Z

Codecov Report

❌ Patch coverage is 93.65079% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.24%. Comparing base (f06b45a) to head (e989b87).

Files with missing lines	Patch %	Lines
servicex_app/servicex_app/models.py	80.00%	3 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1455      +/-   ##
===========================================
+ Coverage    89.20%   89.24%   +0.04%     
===========================================
  Files          103      104       +1     
  Lines         3732     3785      +53     
  Branches       460      465       +5     
===========================================
+ Hits          3329     3378      +49     
- Misses         326      329       +3     
- Partials        77       78       +1

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

for more information, see https://pre-commit.ci

…hub.com/ssl-hep/ServiceX into 1296-add-cancel-all-button-to-dashboard

ponyisi · 2026-05-22T02:33:18Z

+        if current_app.config.get("ENABLE_AUTH"):
+            user = self.get_requesting_user()
+            user_id = user.id if user is not None else None
+            transform_reqs = TransformRequest.query.filter(


I feel Ben always likes these to be added to the model class so they can be reused easily

Two class methods were added to support this.

BenGalewsky · 2026-05-22T12:14:59Z

+        cls.transformer_manager = transformer_manager
+
+    @auth_required
+    def get(self):


Not to be "that guy", but this should be a POST and not a GET since it is taking an action...

Yeah you're right, I copied the pattern from the existing cancel route.

Both Cancel and Cancel All were updated to use post.

Hm, can cancel be called by the frontend CLI?

Yes, it can... I'm not sure it's worth making a breaking change over. Maybe keep cancel endpoint a GET and make CancelAll a POST.

Good catch, @ponyisi

I've reverted the cancel to use get.

Could we support the same logic on both get and post and then deprecate the get on some timeline?

Sounds reasonable. (Sounds like a feature flag. :-) )

@ponyisi @BenGalewsky this has been finalized, with an additional frontend PR added to support it.

for more information, see https://pre-commit.ci

…hub.com/ssl-hep/ServiceX into 1296-add-cancel-all-button-to-dashboard

for more information, see https://pre-commit.ci

…hub.com/ssl-hep/ServiceX into 1296-add-cancel-all-button-to-dashboard

for more information, see https://pre-commit.ci

…96-add-cancel-all-button-to-dashboard

…hub.com/ssl-hep/ServiceX into 1296-add-cancel-all-button-to-dashboard

…96-add-cancel-all-button-to-dashboard

for more information, see https://pre-commit.ci

…hub.com/ssl-hep/ServiceX into 1296-add-cancel-all-button-to-dashboard

for more information, see https://pre-commit.ci

…hub.com/ssl-hep/ServiceX into 1296-add-cancel-all-button-to-dashboard

…96-add-cancel-all-button-to-dashboard

BenGalewsky · 2026-07-03T17:19:38Z

            mock_conn.execute.assert_called_once()
+
+
+class TestShutdownPod:


Why are these tests here, and not in test_transformer_manager.py?

BenGalewsky · 2026-07-03T17:21:12Z

+            .all()
+        )
+
+    def shutdown_pod(self, transformer_manager: TransformerManager):


This doesn't belong in the database models. I think it should be an operation in transformer_manager.py

Agree, in my earlier comment I just meant that the DB query (active_user_transformations) should be in the model class

BenGalewsky · 2026-07-03T17:22:39Z

            "capabilities": [
                "poll_local_transformation_results",
                "long_sample_titles_10240",
+                "post_cancel_transform",


I find this name confusing... it sounds like it describes something that happens after a cancel (post-cancel-bliss). Maybe cancel_transform_post_method or somthing

MattShirley added 2 commits May 20, 2026 12:06

add cancel-all route

7ce3b68

add tests

4ab321d

MattShirley linked an issue May 21, 2026 that may be closed by this pull request

Add Cancel All Button to Dashboard #1296

Open

[pre-commit.ci] auto fixes from pre-commit.com hooks

ee8ba48

for more information, see https://pre-commit.ci

MattShirley and others added 4 commits May 21, 2026 16:58

hide Cancel All when ENABLE_AUTH=False

407a6a3

[pre-commit.ci] auto fixes from pre-commit.com hooks

708070c

for more information, see https://pre-commit.ci

move button on ui

30947bf

Merge branch '1296-add-cancel-all-button-to-dashboard' of https://git…

a1135d7

…hub.com/ssl-hep/ServiceX into 1296-add-cancel-all-button-to-dashboard

MattShirley marked this pull request as ready for review May 21, 2026 22:09

MattShirley requested review from BenGalewsky and ponyisi May 21, 2026 22:12

ponyisi reviewed May 22, 2026

View reviewed changes

BenGalewsky reviewed May 22, 2026

View reviewed changes

MattShirley and others added 12 commits May 22, 2026 12:15

refactor into model classmethods

b03005b

[pre-commit.ci] auto fixes from pre-commit.com hooks

e482010

for more information, see https://pre-commit.ci

update tests

0bdf6c4

Merge branch '1296-add-cancel-all-button-to-dashboard' of https://git…

4a11070

…hub.com/ssl-hep/ServiceX into 1296-add-cancel-all-button-to-dashboard

update test_cancel.py as well

5ec4043

[pre-commit.ci] auto fixes from pre-commit.com hooks

cf757ed

for more information, see https://pre-commit.ci

improve testing gaps

43a7c64

Merge branch '1296-add-cancel-all-button-to-dashboard' of https://git…

e813e2d

…hub.com/ssl-hep/ServiceX into 1296-add-cancel-all-button-to-dashboard

[pre-commit.ci] auto fixes from pre-commit.com hooks

3096aaf

for more information, see https://pre-commit.ci

Merge branch 'develop' of https://github.com/ssl-hep/ServiceX into 12…

6dace18

…96-add-cancel-all-button-to-dashboard

Merge branch '1296-add-cancel-all-button-to-dashboard' of https://git…

70bf3e5

…hub.com/ssl-hep/ServiceX into 1296-add-cancel-all-button-to-dashboard

change get to post

6e5c05d

MattShirley requested review from BenGalewsky and ponyisi May 28, 2026 19:51

MattShirley added 2 commits June 1, 2026 15:22

change cancel to use get instead of post

3e7cc02

Merge branch 'develop' of https://github.com/ssl-hep/ServiceX into 12…

51dc2cb

…96-add-cancel-all-button-to-dashboard

MattShirley and others added 13 commits June 2, 2026 14:40

support both CancelTransform get and post

6b3da2f

[pre-commit.ci] auto fixes from pre-commit.com hooks

d6b8f55

for more information, see https://pre-commit.ci

add capabilities entry for this

35fab85

Merge branch '1296-add-cancel-all-button-to-dashboard' of https://git…

4398cc3

…hub.com/ssl-hep/ServiceX into 1296-add-cancel-all-button-to-dashboard

[pre-commit.ci] auto fixes from pre-commit.com hooks

8817e24

for more information, see https://pre-commit.ci

add comments to the CancelTransform

56f5ef8

Merge branch '1296-add-cancel-all-button-to-dashboard' of https://git…

5e426c0

…hub.com/ssl-hep/ServiceX into 1296-add-cancel-all-button-to-dashboard

Merge branch 'develop' of https://github.com/ssl-hep/ServiceX into 12…

2bfecfa

…96-add-cancel-all-button-to-dashboard

refactor how transformer manager is injected

4d9025e

change how transformer manager is injected into cancel all

8bd3ea5

add typing guard

8ecfb1b

update tests

96f7507

refactor tests to correctly mock shutdown_pod

e989b87

BenGalewsky reviewed Jul 3, 2026

View reviewed changes

		mock_conn.execute.assert_called_once()


		class TestShutdownPod:

Uh oh!

Uh oh!

Conversation

MattShirley commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MattShirley commented May 21, 2026 •

edited

Loading

codecov Bot commented May 21, 2026 •

edited

Loading