Logstash for DID finders#1183
Open
ponyisi wants to merge 4 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1183 +/- ##
========================================
Coverage 89.20% 89.20%
========================================
Files 103 103
Lines 3732 3732
Branches 460 460
========================================
Hits 3329 3329
Misses 326 326
Partials 77 77 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ponyisi
commented
Jul 8, 2026
|
|
||
| initialize_logging(component_name="atom_did_finder") | ||
|
|
||
| __log = logging.getLogger(__name__) |
Collaborator
Author
There was a problem hiding this comment.
shouldn't this variable take the result of initialize_logging ?
ponyisi
commented
Jul 8, 2026
| from .replica_distance import ReplicaSorter | ||
|
|
||
| __log = logging.getLogger(__name__) | ||
| initialize_logging(component_name="rucio_did_finder") |
Collaborator
Author
There was a problem hiding this comment.
is this necessary if not used in this file?
ponyisi
commented
Jul 8, 2026
ponyisi
left a comment
ponyisi
left a comment
Collaborator
Author
There was a problem hiding this comment.
See the couple of questions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DID finder logging