fix(tsconfig): resolve all @loadout/* workspace packages#209
Merged
Conversation
…lve them Bun doesn't symlink workspace packages into node_modules, and the root tsconfig only had path mappings for @loadout/types and @loadout/ui. Every other workspace import (@loadout/exec, plugin-storage, steam-cdp, game-library, etc.) failed with TS2307, which cascaded into implicit-any and possibly-null errors across apps/loadout and the plugins. Add explicit paths entries for all 17 @loadout/* packages, mirroring the existing types/ui pattern. `bun run typecheck` now passes clean (was 22 errors). Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bun run typecheckwas failing with 22 errors even thoughbun installhad run. Root cause: Bun doesn't symlink workspace packages intonode_modules/@loadout/, and the roottsconfig.jsononly hadpathsentries for@loadout/typesand@loadout/ui. Every other workspace import fell through to node resolution and failed:TS2307: Cannot find module '@loadout/exec' / '@loadout/plugin-storage' / '@loadout/steam-cdp' / '@loadout/game-library'acrossapps/loadoutand the plugins.any, cascading intoTS7006(implicit any onproc,e,g) andTS2531(possibly null) errors.This adds explicit
pathsentries for all 17@loadout/*packages, mirroring the existingtypes/uipattern (each pointing at the package'ssrc). Bun itself honors these samepaths, so runtime resolution benefits too.bun run typechecknow passes clean (22 → 0 errors).Test plan
bun run typecheckpasses (was 22 errors, now 0)chore(release):commits)🤖 Generated with Claude Code