Skip to content

Add gem2 installer to use gem2.0.#210

Open
weakish wants to merge 3 commits into
sprinkle-tool:masterfrom
weakish:gem2
Open

Add gem2 installer to use gem2.0.#210
weakish wants to merge 3 commits into
sprinkle-tool:masterfrom
weakish:gem2

Conversation

@weakish

@weakish weakish commented May 3, 2016

Copy link
Copy Markdown
Contributor

Same as gem installer except it uses gem2.0.

Same as gem installer except it uses `gem2.0`.
@joshgoebel

Copy link
Copy Markdown
Contributor

This should be handled by gem supporting a :binary_name option that changes the default from gem to gem2.0 and then someone who needs this can define a helper gem2 function that just calls gem but merges in the binary_name argument.

In fact I'd be ok with gem2 in the API, but it should be part of gem.rb, not a whole new thing.

Add a new option to Gem installer: `gem_command`.
@weakish

weakish commented Jul 11, 2016

Copy link
Copy Markdown
Contributor Author

it should be part of gem.rb

Merged into gem.rb

This should be handled by gem supporting a :binary_name option that changes the default from gem to gem2.0 and then someone who needs this can define a helper gem2 function

I implemented it as an option gem_command.

@joshgoebel

Copy link
Copy Markdown
Contributor

That's fine, but I also imagined you'd have a gem2 api call that provided an easy way to call it without having to know about the internals of gem_command.

@joshgoebel

Copy link
Copy Markdown
Contributor

Something like:

 def gem2(name, options = {}, &block)
    gem(name, options.merge(:gem_command => "gem2.0"), &block)
end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants