fix: stream records lazily in write_records and _execute_chunk_v2#800
Open
shivamsharma2106 wants to merge 2 commits into
Open
fix: stream records lazily in write_records and _execute_chunk_v2#800shivamsharma2106 wants to merge 2 commits into
shivamsharma2106 wants to merge 2 commits into
Conversation
Ickerday
force-pushed
the
fix/generating-command-oom-list-materialization
branch
from
ae7f1d4 to
c64a592
Compare
Collaborator
|
Whoops, my bad. Reverting |
3 tasks
Ickerday
force-pushed
the
fix/generating-command-oom-list-materialization
branch
from
c64a592 to
ae7f1d4
Compare
Collaborator
|
@shivamsharma2106 could I ask you to have a look at #804 and try it out? It's a dirty workaround, but getting rid of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
_execute_chunk_v2was accumulating all records into a list before writing them, causing OOM (out-of-memory) errors when generating commands produced large result sets. Similarly,write_recordswas materializing the full iterator into a list upfront.Fix:
_execute_chunk_v2:write each record immediately as it is generated instead of buffering all records first.write_records: return early if records is NotImplemented instead of materializing into an empty list.This makes both methods stream records lazily, avoiding unnecessary memory allocation.