Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions uint_slice.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ func (s *uintSliceValue) Set(val string) error {
ss := strings.Split(val, ",")
out := make([]uint, len(ss))
for i, d := range ss {
u, err := strconv.ParseUint(d, 10, 0)
u, err := strconv.ParseUint(d, 0, 0)
if err != nil {
return err
}
Expand Down Expand Up @@ -51,7 +51,7 @@ func (s *uintSliceValue) String() string {
}

func (s *uintSliceValue) fromString(val string) (uint, error) {
t, err := strconv.ParseUint(val, 10, 0)
t, err := strconv.ParseUint(val, 0, 0)
if err != nil {
return 0, err
}
Expand Down Expand Up @@ -101,7 +101,7 @@ func uintSliceConv(val string) (interface{}, error) {
ss := strings.Split(val, ",")
out := make([]uint, len(ss))
for i, d := range ss {
u, err := strconv.ParseUint(d, 10, 0)
u, err := strconv.ParseUint(d, 0, 0)
if err != nil {
return nil, err
}
Expand Down
34 changes: 34 additions & 0 deletions uint_slice_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,40 @@ func TestUIS(t *testing.T) {
}
}

func TestUISHex(t *testing.T) {
var uis []uint
f := setUpUISFlagSet(&uis)

vals := []string{"0x1", "0x2", "0x10"}
arg := fmt.Sprintf("--uis=%s", strings.Join(vals, ","))
err := f.Parse([]string{arg})
if err != nil {
t.Fatal("expected no error; got", err)
}
for i, v := range uis {
u, err := strconv.ParseUint(vals[i], 0, 0)
if err != nil {
t.Fatalf("got error: %v", err)
}
if uint(u) != v {
t.Fatalf("expected uis[%d] to be %s but got: %d", i, vals[i], v)
}
}
getUIS, err := f.GetUintSlice("uis")
if err != nil {
t.Fatalf("got error: %v", err)
}
for i, v := range getUIS {
u, err := strconv.ParseUint(vals[i], 0, 0)
if err != nil {
t.Fatalf("got error: %v", err)
}
if uint(u) != v {
t.Fatalf("expected uis[%d] to be %s but got: %d from GetUintSlice", i, vals[i], v)
}
}
}

func TestUISDefault(t *testing.T) {
var uis []uint
f := setUpUISFlagSetWithDefault(&uis)
Expand Down
Loading