This repository was archived by the owner on Jun 10, 2022. It is now read-only.
Support Updates in Newest Version of MFNA#27
Open
newlandk wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@spenceation I'm not sure how much testing or validation you perform on a change like this. I found that adding this setting for Zeep was necessary to work with newer version of MFNA.
I found this comment from the Zeep maintainer that pointed me in this direction: mvantellingen/python-zeep#307 (comment)
I don't have an older environment to test against to understand if it changes any behavior with the older (2019) versions of MFNA.
Please let me know if you have any thoughts around this update as I'm not overly familiar with Zeep. Thanks!