Fix flatten_spectra_multi colors and trange handling#423
Open
huangzesen wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
colorswhenflatten_spectra_multiis used with explicittime=values.trange=handling by setting the averaging range and using the range midpoint as the representative selected time.COLORSandTRANGEheader comments to match the actual selected-time/spectrum behavior.Details
KEYWORD_SET(colors)for default-color detection because color index0is valid.selected_timesis known.time=andtrange=are supplied, this implementation usestrange=and documents that precedence.Validation
git diff --checktrange_inhandling, late default colors,time=preserving caller colors, existing averaging throughtrange, and finalendCloses #52.
Closes #53.