Fix deploy workflow npm authentication for package publish#8
Merged
Conversation
Agent-Logs-Url: https://github.com/spearwolf/shadow-objects/sessions/4f20d95e-f081-4e4d-b878-69e3d7ac539c Co-authored-by: spearwolf <[email protected]>
Agent-Logs-Url: https://github.com/spearwolf/shadow-objects/sessions/4f20d95e-f081-4e4d-b878-69e3d7ac539c Co-authored-by: spearwolf <[email protected]>
Copilot created this pull request from a session on behalf of
spearwolf
May 9, 2026 14:05
View session
There was a problem hiding this comment.
Pull request overview
This PR fixes the Deployment GitHub Actions workflow so the Publish packages step can authenticate to registry.npmjs.org during pnpm run publishNpmPkg, resolving npm publish failures due to missing auth (ENEEDAUTH).
Changes:
- Adds
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}to the publish step environment in.github/workflows/deploy.yml.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deployment workflow was failing during
npm publishwithENEEDAUTHbecause no npm auth token was available in the publish step. This change wires npm auth intodeploy.ymlso publish jobs can authenticate againstregistry.npmjs.org.Root cause addressed
Publish packagesran withoutNODE_AUTH_TOKEN, so npm treated the runner as unauthenticated.Workflow change
.github/workflows/deploy.ymlto pass the npm secret into the publish step environment:NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}Scope