reimplement: SHC_3BB0A8C1_0x00479AB0 100%#72
Merged
Conversation
TheRedDaemon
force-pushed
the
reimpl/SHC_3BB0A8C1_0x00479AB0
branch
from
24096a2 to
17401b4
Compare
Contributor
Author
|
Hi @gynt, I still have the issue with the Can I just leave the removal of this include in this MR and you adapt the export, or should we do something else? |
Contributor
|
Resolved in a1971f3 |
TheRedDaemon
force-pushed
the
reimpl/SHC_3BB0A8C1_0x00479AB0
branch
from
17401b4 to
24a7f10
Compare
gynt
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft, since there are two problems at the moment:
usingand forward declaring it. The question here however would be: Are these structures relevant for us, or can we just use "dplay.h"?