Skip to content

feat: migrate avoid_final_with_getter#242

Open
andrew-bekhiet-solid wants to merge 3 commits into
analysis_server_migrationfrom
migrate/avoid_final_with_getter
Open

feat: migrate avoid_final_with_getter#242
andrew-bekhiet-solid wants to merge 3 commits into
analysis_server_migrationfrom
migrate/avoid_final_with_getter

Conversation

@andrew-bekhiet-solid
Copy link
Copy Markdown
Collaborator

refactor: extract GetterVariableVisitor into a file
refactor: extract GetterReferenceId into a file
test(avoid_final_with_getter): migrate tests

refactor: extract GetterVariableVisitor into a file
refactor: extract GetterReferenceId into a file
test(avoid_final_with_getter): migrate tests
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the avoid_final_with_getter lint rule and its quick fix to the new analysis_server_plugin API, replacing the custom lint implementation with AnalysisRule and ResolvedCorrectionProducer. Feedback on the changes suggests enhancing the quick fix to rename all references to the private variable and getter to avoid compilation errors, and extending getterReferenceId to support explicit this. accesses and block bodies.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant