fix(world-cup): pin codama to stop IDL drift#635
Merged
Conversation
The scheduled `Just` workflow always failed at `check-generated`. codama floated within 0.9.x, so CI regenerated idl/world_cup.json (adds `constants: []`, spec version 1.0.0 -> 1.6.0) and the committed IDL no longer matched. Pin codama to =0.9.3 and commit the regenerated IDL so the check is deterministic.
amilz
approved these changes
Jul 16, 2026
amilz
left a comment
Collaborator
There was a problem hiding this comment.
Deterministic fix: pin codama =0.9.3 and regen world_cup.json to match. CI green, changes match intent. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Justworkflow always failed ongames/world-cup/pinocchioat thecheck-generatedstep.codama = "0.9.2"(caret) floated to0.9.3, whose IDL output differs from the committedidl/world_cup.json(adds"constants": [], bumps spec version1.0.0→1.6.0). No lockfile is committed for this sub-project, so CI resolved fresh every run → deterministic drift → failed every scheduled run.codama = "=0.9.3"so IDL generation is deterministic.idl/world_cup.jsonto match.Test Plan
just generate-idltwice produces zero diff against the committed IDL.git diff --quiet -- idl clients/typescript/src/generated clients/rust/src/generatedis clean →check-generatedpasses.Notes
clients/*/src/generated) are gitignored, so thecargo-fmt not installedwarning in the CI log is cosmetic and does not affectcheck-generated.