refactor(Reanimated): rename Mutable.setDirty to setDirtyFlag - #10261
refactor(Reanimated): rename Mutable.setDirty to setDirtyFlag#10261tjzel wants to merge 4 commits into
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe mutable dirty-state method is renamed from ChangesMutable dirty-state API
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This is a localized API rename with no actionable merge-blocking risk remaining; it is merge-ready after normal checks and review. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
a7e2f70 to
c2f2541
Compare
f442037 to
e681d0d
Compare
…zel/reanimated/mutable-mark-dirty
Note
This PR description is AI-generated.
Summary
Depends on #10298.
Merge only after Reanimated 4.6.0 is released.
I renamed the mutable-side dirty flag setter from
Mutable.setDirtytoMutable.setDirtyFlag. This will avoid adding confusion when I implement a Synchronizable that hassetDirtymethod later on. I also moved the setter into a local function inmutableHostDecorator, so the call from the_valuesetter is type checked - it used to go throughthis, whichObject.definePropertiestypes asany.Test plan
n/a