fix: add fontVariationSettings to style properties config - #10239
Draft
tjzel wants to merge 2 commits into
Draft
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe style configuration now includes ChangesFont variation style support
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This pull request was authored by AI on behalf of tjzel.
Failing job: https://github.com/software-mansion/react-native-reanimated/actions/runs/31530561295/job/93909391982
Summary
The nightly leg of the TypeScript compatibility test has failed since React Native
0.88.0-nightly-20260810, which added a new style propfontVariationSettings.PropsBuilderConfig<P>maps overkeyof Required<P>, so every style key is a mandatory key ofSTYLE_PROPERTIES_CONFIGand any prop React Native adds breaksconfig.tswith TS2741.I added the prop with the value
false, matching how the other props we do not animate are handled — there is no interpolator for it inInterpolatorRegistry.cpp. The@ts-ignoreis functionally required rather than explanatory: on RN 0.83 through 0.87 the key does not exist inAllStyleProps, so without it the object literal raises TS2353 on those legs. This mirrors thebackgroundImageprecedent added for the same reason when RN 0.87 introduced it.The web config needs no change, because its own
PropsBuilderConfigis homomorphic and preserves optionality.Test plan
From
packages/react-native-reanimated, against the locally installed[email protected]:yarn type:check:src:native,yarn type:check:src:web,yarn type:check:legacy-rn-types:srcandyarn eslint src/common/style/config.tsall pass.@ts-ignorereproducesTS2353on the installed version, confirming the directive is required rather than dead weight.RN nightly was not installed locally, so the nightly leg passing is an inference that CI will confirm. The failing runs stopped at the first type-check step, so the later steps never ran against
nightly-20260810; if that nightly changed anything outsideStyleSheetTypes.d.ts, a further failure could surface.Changelog
Unpublishedsection of each changed package'sCHANGELOG.md, or this PR does not changereact-native-reanimatedorreact-native-worklets.