Skip to content

test(mapper): strengthen concurrency and nested-AND coverage #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shihyuho merged 2 commits into from
Jul 16, 2026
Merged

test(mapper): strengthen concurrency and nested-AND coverage #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ffc6b01
test(mapper): strengthen concurrency and nested-AND coverage
shihyuho Jul 16, 2026
6ce3b2a
Merge branch 'jakarta' into test/182-mapper-test-coverage
shihyuho Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions mapper/src/test/java/tw/com/softleader/data/jpa/spec/NestedSpecificationResolverTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,10 @@ void allAnd() {
.extracting("specs", LIST)
.hasSize(2);
depth1.first().isInstanceOf(Equals.class);
depth1
var depth2 =
depth1.element(1).isInstanceOf(Conjunction.class).extracting("specs", LIST).hasSize(2);
depth2.first().isInstanceOf(Equals.class);
depth2
.element(1)
.isInstanceOf(Conjunction.class)
.extracting("specs", LIST)
Expand Down Expand Up @@ -389,7 +392,7 @@ public static class NestedAnd {
@AllArgsConstructor
public static class NestedInNestedAnd {

@NestedSpec String name;
@Spec String name;
}

@Builder
Expand Down
22 changes: 17 additions & 5 deletions mapper/src/test/java/tw/com/softleader/data/jpa/spec/ReflectionDatabindTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import java.util.Collection;
import java.util.Optional;
import java.util.concurrent.CountDownLatch;
import java.util.concurrent.CyclicBarrier;
import lombok.AllArgsConstructor;
import lombok.SneakyThrows;
import org.junit.jupiter.api.Test;
Expand All @@ -49,17 +50,28 @@ void fireOnlyOnce() {

assertThat(databind).hasSize(5);

var numberOfThreads = 1;
// Release every thread at the same instant so multiple threads race into
// getFieldValue() on the *same* Databind instances and genuinely contend on
// the AtomicBoolean CAS + CountDownLatch dedup.
var numberOfThreads = 32;
var service = newFixedThreadPool(numberOfThreads);
var latch = new CountDownLatch(numberOfThreads);
var startBarrier = new CyclicBarrier(numberOfThreads);
var done = new CountDownLatch(numberOfThreads);
for (int i = 0; i < numberOfThreads; i++) {
service.submit(
() -> {
databind.forEach(Databind::getFieldValue);
latch.countDown();
try {
startBarrier.await();
databind.forEach(Databind::getFieldValue);
} catch (Exception e) {
throw new RuntimeException(e);
} finally {
done.countDown();
}
});
}
latch.await();
done.await();
service.shutdown();

databind.forEach(
bind -> {
Expand Down