Skip to content

[Snyk] Security upgrade aiohttp from 3.8.6 to 3.13.4 - #115

Open
Robthreefold wants to merge 1 commit into
mainfrom
snyk-fix-c2e224b045e24e389bc8d39fa9ebeae9
Open

[Snyk] Security upgrade aiohttp from 3.8.6 to 3.13.4#115
Robthreefold wants to merge 1 commit into
mainfrom
snyk-fix-c2e224b045e24e389bc8d39fa9ebeae9

Conversation

@Robthreefold

Copy link
Copy Markdown
Contributor

snyk-top-banner

Snyk has created this PR to fix 10 vulnerabilities in the pip dependencies of this project.

Snyk changed the following file(s):

  • target-counter/requirements.txt

Breaking Change Risk

Merge Risk: High

Notice: This assessment is enhanced by AI.


Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.
  • Some vulnerabilities couldn't be fully fixed and so Snyk will still find them when the project is tested again. This may be because the vulnerability existed within more than one direct dependency, but not all of the affected dependencies could be upgraded.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Allocation of Resources Without Limits or Throttling
🦉 Information Exposure

@Robthreefold
Robthreefold requested a review from a team as a code owner April 2, 2026 19:49
@Robthreefold

Copy link
Copy Markdown
Contributor Author

Merge Risk: High

This upgrade from aiohttp 3.8.6 to 3.13.4 contains significant breaking changes that require developer action.

High-Risk Breaking Changes:

  • Graceful Shutdown Logic: Starting from version 3.10, the application shutdown logic has changed. It no longer waits for all background tasks to complete, only for request handlers. This can lead to data loss or incomplete operations if your application relies on background tasks finishing during shutdown. Action Required: You must review your application's background task management. The official documentation recommends using a library like aiojobs to ensure tasks are properly awaited.
  • CookieJar Format Change: The internal format for cookies saved with CookieJar.save() has changed. Cookies saved with older versions of aiohttp will not be compatible. Action Required: If your application persists cookies using CookieJar.save(), you must run the migration script provided in the changelog to convert them to the new format.

Medium-Risk Changes:

  • Python 3.6 Support Dropped: Support for Python 3.6 was removed starting with the 3.9 release series. Your environment must be using Python 3.7 or newer.

Other Notable Changes:

  • The decode() method on ClientResponse was temporarily made asynchronous in version 3.13.3 but was reverted to a synchronous method in a subsequent patch for backward compatibility.
  • Numerous security vulnerabilities have been patched across these versions, including fixes for request smuggling and header parsing.

Recommendation:
Due to the breaking changes in the shutdown process and cookie handling, a thorough review and testing are required. Pay close attention to any background tasks that run independently of request handlers and any code that relies on persisted cookies.

Source: aiohttp Changelog

Notice 🤖: This content was augmented using artificial intelligence. AI-generated content may contain errors and should be reviewed for accuracy before use.

@Robthreefold

Robthreefold commented Apr 2, 2026

Copy link
Copy Markdown
Contributor Author

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants