This repository was archived by the owner on Feb 4, 2025. It is now read-only.
Snapview v1.1.0#2
Open
Vooord wants to merge 9 commits into
Open
Conversation
pabra
reviewed
Jun 13, 2022
Contributor
|
Hello @Vooord . This MR is too big and includes too many unrelated changes. Please split it. |
Contributor
Author
Hey, @denistakeda, I extracted github-actions into separate pr-3 |
denistakeda
reviewed
Jul 11, 2022
denistakeda
reviewed
Jul 27, 2022
denistakeda
reviewed
Jul 27, 2022
|
|
||
| /* -- | ||
|
|
||
| God damn hard |
Contributor
Author
There was a problem hiding this comment.
I've removed that and changed the split in just two parts (Common and Uncommon), is it okay? :)
denistakeda
suggested changes
Jul 27, 2022
denistakeda
left a comment
denistakeda
left a comment
Contributor
There was a problem hiding this comment.
Very good, I like it! Just small changes needed
- `Updater` instead of `Property`; - `UpdaterConstructor` (e.g. `style`, `className`, etc.); - `UpdaterConstructorCreators` to easily create typical `UpdaterConstructor` Used those new concepts wherever I could
Member
|
I copied the changes to https://github.com/snapview/sunrise-dom/tree/v1.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored
NodesandProperties;Added main
indexfile;