fix auto-retry tolerance range validation - #271
Closed
snapetech wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
double-typedRangeAttributefor the download auto-retry alternate-source size toleranceWhy
The property is a
double, but its range annotation used integer operands.RangeAttributeconverted fractional values to integers during validation, so values such as-0.1and100.1rounded into the accepted range.Impact
YAML validation and startup validation now reject every fractional tolerance below 0 or above 100 instead of accepting values close to the boundaries.
Validation
dotnet test tests/slskd.Tests.Unit/slskd.Tests.Unit.csproj -c Release --filter 'FullyQualifiedName~OptionsControllerTests' --no-restore