retain valid options after rejected reload - #270
Closed
snapetech wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Root cause
The default
OptionsMonitorevicts its cached value before constructing and validating the replacement. When a watched file contains an invalid value, construction throwsOptionsValidationExceptionand leaves the cache empty. Background services then resolve the same invalid options object; an unhandled exception fromWishlistServicereaches the defaultStopHostbehavior and shuts down the entire application.Impact
Invalid watched configuration still receives the existing validation failure, but singleton and background consumers continue using the last valid configuration. A later valid file change is applied normally without restarting the process.
Validation
dotnet test tests/slskd.Tests/slskd.Tests.csproj --no-restore: 70 passeddotnet format slskd.sln whitespace --verify-no-changes --include ...: passedsoulseek.listen_port: 1023rejected, host retained its valid runtime options, subsequent valid reload applied