Fix live listener reconfiguration state and obfuscation - #266
Closed
snapetech wants to merge 2 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
RequiresReconnectfromsoulseek.listen_ip_addressandsoulseek.listen_portPeerObfuscationOptionspatches before listener rebindingRoot causes
Application.OptionsMonitor_OnChangeORed the option attributes intoPendingReconnecteven whenSoulseekClient.ReconfigureOptionsAsync(...)returnedfalse. Soulseek.NET already rebinds the regular listener and advertises it without reconnecting.The vendored Soulseek.NET runtime also omitted
PeerObfuscationOptionsfrom bothOptions.With(...)calls during reconfiguration. A regular port change therefore rebound and advertised the new regular endpoint while retaining the old type-1 listener port and metadata until restart.Frozen-runtime differentials reproduced both contradictions with a login-capable local Soulseek server and direct socket probes.
Validation
dotnet test tests/slskd.Tests.Unit/slskd.Tests.Unit.csproj --filter FullyQualifiedName~ApplicationLifecycleTests -v:minimal— 8 passeddotnet test vendor/slskNet.Runtime/tests/Soulseek.Tests.Unit/Soulseek.Tests.Unit.csproj --filter FullyQualifiedName~ReconfigureOptionsAsyncTests -v:minimal— 29 passedgit diff --check