docs: clarify allow_private_registry_fetch is a blanket SSRF opt-out (MCP-3206)#751
Open
Dumbris wants to merge 1 commit into
Open
docs: clarify allow_private_registry_fetch is a blanket SSRF opt-out (MCP-3206)#751Dumbris wants to merge 1 commit into
Dumbris wants to merge 1 commit into
Conversation
Deploying mcpproxy-docs with
|
| Latest commit: |
f4d706d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://10bbc79f.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://docs-mcp-3206-ssrf-optout-cl.mcpproxy-docs.pages.dev |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 28118907756 --repo smart-mcp-proxy/mcpproxy-go
|
The allow_private_registry_fetch flag is all-or-nothing: enabling it lifts the registry SSRF guard for every non-routable range at once, including the 169.254.169.254 cloud-metadata endpoint. Enabling it for a localhost dev registry therefore also re-opens the cloud-metadata SSRF vector. Document this sharp edge in the config doc comment, docs/configuration.md, and docs/registries.md, plus note the flag only takes effect on daemon (re)start / config reload. Related #745 Related MCP-3206
Dumbris
force-pushed
the
docs/mcp-3206-ssrf-optout-clarify
branch
from
cec0160 to
f4d706d
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Approved (CEO fallback MCP-3392 / MCP-3066): review verdict ACCEPT at f4d706d. Docs + comment-only PR; qa-gate blessed by CEO after confirming no functional Go changes. Arming auto-merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Docs-only clarification surfaced in the v0.45.0 QA pass (SSRF-05, MCP-1076/#745).
The
allow_private_registry_fetchflag is all-or-nothing: whentrueit lifts the registry SSRF guard for every non-routable range at once — loopback, RFC1918/CGNAT private, link-local and the169.254.169.254cloud-metadata endpoint. So enabling it for a localhost dev registry also re-opens the cloud-metadata SSRF vector (verified:registry add-source https://169.254.169.254/...then succeeds). This is by design, but a sharp edge worth spelling out.Changes (docs-only)
internal/config/config.go— expand theAllowPrivateRegistryFetchdoc comment to state the blanket nature, the cloud-metadata re-exposure, the trusted-host recommendation, and that the flag only takes effect on daemon (re)start / config reload.docs/configuration.md— add adocs/registries.md— add the opt-out note alongside the existing SSRF guard description.oas/swagger.yaml/oas/docs.go— regenerated (swag derives the schema description from the config doc comment).Verification
gofmt -lclean;go build ./internal/config/ok.make swaggerregenerated and committed; pre-pushswagger-verifypasses.Provenance: QA report
~/mcpproxy-qa/mcpproxy-qa-v0.45.0.html(SSRF-05 + security note).Related #745