Skip to content

fix: preserve unresolved parameter references - #2644

Merged
MikeEdgar merged 3 commits into
smallrye:mainfrom
arnabnandy7:fix/unresolvedParameterRefs
Aug 27, 2026
Merged

fix: preserve unresolved parameter references#2644
MikeEdgar merged 3 commits into
smallrye:mainfrom
arnabnandy7:fix/unresolvedParameterRefs

Conversation

@arnabnandy7

Copy link
Copy Markdown
Contributor

Description

Fixes #2643.

Multiple unresolved parameter references were treated as duplicates because their name, in, and style values were all null during annotation scanning.

Referenced parameters now use their $ref as the duplicate key. Inline parameters continue to use name, in, and style.

Changes

  • Preserve distinct unresolved parameter references.
  • Retain existing duplicate handling for inline parameters.
  • Add regression coverage for:
    • Repeated @Parameter annotations.
    • Explicit @Parameters containers.
    • Referenced components supplied after scanning by a filter.

Testing

./mvnw -pl extension-jaxrs -am -Dtest=ParameterScanTests#testMultipleUnresolvedParameterRefs test

@arnabnandy7
arnabnandy7 requested a review from MikeEdgar August 27, 2026 05:47
@MikeEdgar

Copy link
Copy Markdown
Member

@arnabnandy7 the CI is failing due to formatting. Please take a look at the error message for details. Basically, just run the build locally and commit the formatting changes.

@arnabnandy7

Copy link
Copy Markdown
Contributor Author

@arnabnandy7 the CI is failing due to formatting. Please take a look at the error message for details. Basically, just run the build locally and commit the formatting changes.

sure I missed running second time @MikeEdgar

@MikeEdgar MikeEdgar added this to the 4.4.0 milestone Aug 27, 2026
@MikeEdgar
MikeEdgar merged commit 9e6aafa into smallrye:main Aug 27, 2026
18 checks passed
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
53.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiple unresolved parameter references are treated as duplicates

2 participants