Fix uninitialized atomic_bool in LogWriter causing spurious logfile reopen - #819
Open
MarkRose wants to merge 1 commit into
Open
Fix uninitialized atomic_bool in LogWriter causing spurious logfile reopen#819MarkRose wants to merge 1 commit into
MarkRose wants to merge 1 commit into
Conversation
…eopen
- LogWriter::m_reopen_log (src/misc/LogWriter.h) was a std::atomic_bool
with no in-class initializer and was never set in the constructor. On
C++17 (which this project targets), a default-constructed atomic_bool
is left with an indeterminate value rather than being value-initialized
(that behavior only arrived in C++20). The writer thread reads this flag
before the first call to reopenLogfile(), so on startup it could read
an indeterminate garbage value and spuriously reopen the logfile on the
very first log line. Fixed by giving m_reopen_log an explicit `{false}`
initializer.
Co-Authored-By: Claude Opus 4.8 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with no in-class initializer and was never set in the constructor. On
C++17 (which this project targets), a default-constructed atomic_bool
is left with an indeterminate value rather than being value-initialized
(that behavior only arrived in C++20). The writer thread reads this flag
before the first call to reopenLogfile(), so on startup it could read
an indeterminate garbage value and spuriously reopen the logfile on the
very first log line. Fixed by giving m_reopen_log an explicit
{false}initializer.
Co-Authored-By: Claude Opus 4.8 [email protected]