Fix child Tx object leak in MultiTx on init failure - #817
Open
MarkRose wants to merge 1 commit into
Open
Conversation
- MultiTx::initialize() creates a child Tx via TxFactory::createNamedTx() and then calls tx->initialize() on it. If that initialize() call fails, the function returned false immediately without freeing the just-created tx object. Since the failed tx was never added to the txs list (that only happens after the success check), it was never reachable from ~MultiTx() and leaked. Now the failure path deletes the tx before returning. Co-Authored-By: Claude Opus 4.8 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and then calls tx->initialize() on it. If that initialize() call fails,
the function returned false immediately without freeing the just-created
tx object. Since the failed tx was never added to the txs list (that only
happens after the success check), it was never reachable from ~MultiTx()
and leaked. Now the failure path deletes the tx before returning.
Co-Authored-By: Claude Opus 4.8 [email protected]
This PR also adds a unit test (
MultiTxTest.cpp). It is auto-discovered and executed by the CTest suite proposed in #762 once that is merged; without that suite present the test file is inert and does not affect the build.