Fix unsigned integer underflow in WAV header ChunkSize parsing - #815
Open
MarkRose wants to merge 1 commit into
Open
Fix unsigned integer underflow in WAV header ChunkSize parsing#815MarkRose wants to merge 1 commit into
MarkRose wants to merge 1 commit into
Conversation
- In WavFileQueueItem::initialize() (MsgHandler.cpp), the RIFF ChunkSize field is a uint32_t. The subchunk-parsing loop computed `rest_size = chunk_size - 4` in unsigned arithmetic before assigning it to the signed int64_t rest_size. A WAV file with a ChunkSize smaller than 4 (e.g. 0-3) caused this subtraction to wrap around to a huge unsigned value (~4.29e9), which was then stored as a large positive rest_size, driving the subchunk-reading loop far beyond what the file actually contains instead of being rejected as malformed. The fix validates that chunk_size is at least 4 before subtracting, returning false with a warning otherwise, and performs the subtraction in signed 64-bit arithmetic. Co-Authored-By: Claude Opus 4.8 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
field is a uint32_t. The subchunk-parsing loop computed
rest_size = chunk_size - 4in unsigned arithmetic before assigning itto the signed int64_t rest_size. A WAV file with a ChunkSize smaller
than 4 (e.g. 0-3) caused this subtraction to wrap around to a huge
unsigned value (~4.29e9), which was then stored as a large positive
rest_size, driving the subchunk-reading loop far beyond what the file
actually contains instead of being rejected as malformed. The fix
validates that chunk_size is at least 4 before subtracting, returning
false with a warning otherwise, and performs the subtraction in signed
64-bit arithmetic.
Co-Authored-By: Claude Opus 4.8 [email protected]
This PR also adds a unit test (
MsgHandlerWavChunkSizeTest.cpp). It is auto-discovered and executed by the CTest suite proposed in #762 once that is merged; without that suite present the test file is inert and does not affect the build.