Fix stale PTT pin used when PttHidraw reopens the HID device - #804
Open
MarkRose wants to merge 1 commit into
Open
Fix stale PTT pin used when PttHidraw reopens the HID device#804MarkRose wants to merge 1 commit into
MarkRose wants to merge 1 commit into
Conversation
- PttHidraw::setTxOn() built its 5-byte HID GPIO report from m_pin before checking whether the device needed to be reopened. When a prior write() failure had closed the device, closeDevice() resets m_pin to 0, so the very next setTxOn(true) call assembled a no-op report (all zero GPIO bits) using the stale m_pin, and only afterwards reopened the device and restored the real pin mask. The no-op report was written successfully and setTxOn() returned true, so the caller believed PTT had been keyed while the GPIO line never actually changed. Fixed by reopening the device (and thus refreshing m_pin/m_active_low) before building the report, so the report always reflects the currently configured pin. Co-Authored-By: Claude Opus 4.8 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
before checking whether the device needed to be reopened. When a
prior write() failure had closed the device, closeDevice() resets
m_pin to 0, so the very next setTxOn(true) call assembled a no-op
report (all zero GPIO bits) using the stale m_pin, and only
afterwards reopened the device and restored the real pin mask. The
no-op report was written successfully and setTxOn() returned true,
so the caller believed PTT had been keyed while the GPIO line never
actually changed. Fixed by reopening the device (and thus
refreshing m_pin/m_active_low) before building the report, so the
report always reflects the currently configured pin.
Co-Authored-By: Claude Opus 4.8 [email protected]