Fix crash and per-event recompile of ACTIVATE_ON_TG regex in LinkManager - #802
Open
MarkRose wants to merge 1 commit into
Open
Fix crash and per-event recompile of ACTIVATE_ON_TG regex in LinkManager#802MarkRose wants to merge 1 commit into
MarkRose wants to merge 1 commit into
Conversation
- LinkManager::onReceivedTgUpdated built a new std::regex from the ACTIVATE_ON_TG configuration string on every received TG update event. An invalid regex pattern therefore threw std::regex_error from inside the receivedTgUpdated signal handler, which is never caught, causing svxlink to terminate. It was also wastefully recompiled on every event even when the pattern was valid. Patterns are now compiled once and cached (keyed by link and logic name) the first time they are needed. LinkManager::initialize() now eagerly compiles and validates every ACTIVATE_ON_TG pattern while reading the configuration, reporting an error and failing initialization for any invalid pattern instead of letting it surface later as a runtime crash. onReceivedTgUpdated reuses the cached, already-validated regex instead of rebuilding it. Co-Authored-By: Claude Opus 4.8 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LinkManager::onReceivedTgUpdated built a new std::regex from the
ACTIVATE_ON_TG configuration string on every received TG update event.
An invalid regex pattern therefore threw std::regex_error from inside
the receivedTgUpdated signal handler, which is never caught, causing
svxlink to terminate. It was also wastefully recompiled on every event
even when the pattern was valid.
Patterns are now compiled once and cached (keyed by link and logic
name) the first time they are needed. LinkManager::initialize() now
eagerly compiles and validates every ACTIVATE_ON_TG pattern while
reading the configuration, reporting an error and failing
initialization for any invalid pattern instead of letting it surface
later as a runtime crash. onReceivedTgUpdated reuses the cached,
already-validated regex instead of rebuilding it.
Co-Authored-By: Claude Opus 4.8 [email protected]