Fix CmdParser::removeCmd erasing the wrong command on duplicate IDs - #801
Open
MarkRose wants to merge 1 commit into
Open
Fix CmdParser::removeCmd erasing the wrong command on duplicate IDs#801MarkRose wants to merge 1 commit into
MarkRose wants to merge 1 commit into
Conversation
- CmdParser::removeCmd() looked up the map entry to erase by command string only, without checking that the stored pointer matched the Command being removed. addCmd() refuses to overwrite an existing entry when two commands share the same command string, so the duplicate is never stored in the map. However, when that rejected duplicate is later deleted, its destructor calls removeCmd(this), which found the map entry by string, matched the *original* still-in-use command, and erased it. This silently unregistered a live command from the parser, leaving processCmd() unable to reach it anymore. Fixed by also comparing the mapped pointer against the Command instance being removed before erasing, so removeCmd() only ever removes its own entry. Co-Authored-By: Claude Opus 4.8 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
string only, without checking that the stored pointer matched the
Command being removed. addCmd() refuses to overwrite an existing
entry when two commands share the same command string, so the
duplicate is never stored in the map. However, when that rejected
duplicate is later deleted, its destructor calls removeCmd(this),
which found the map entry by string, matched the original
still-in-use command, and erased it. This silently unregistered a
live command from the parser, leaving processCmd() unable to reach
it anymore. Fixed by also comparing the mapped pointer against the
Command instance being removed before erasing, so removeCmd() only
ever removes its own entry.
Co-Authored-By: Claude Opus 4.8 [email protected]