Fix null-pointer dereferences from failed device/connection init - #798
Open
MarkRose wants to merge 1 commit into
Open
Fix null-pointer dereferences from failed device/connection init#798MarkRose wants to merge 1 commit into
MarkRose wants to merge 1 commit into
Conversation
RefCountingPty::instance() no longer inserts a NULL entry into the ptys() map when open() fails, preventing a later instance() call from dereferencing a null pty via m_refs += 1. NetRx::~NetRx() guards tcp_con->deleteInstance() with a null check, since tcp_con stays 0 when initialize() returns early. NetTx::~NetTx() gets the same tcp_con null guard as NetRx::~NetRx() above. PttPty::~PttPty() guards pty->destroy() with a null check, since pty stays 0 when initialize() fails before RefCountingPty is obtained. Co-Authored-By: Claude Opus 4.8 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RefCountingPty::instance() no longer inserts a NULL entry into
the ptys() map when open() fails, preventing a later instance() call
from dereferencing a null pty via m_refs += 1.
NetRx::~NetRx() guards tcp_con->deleteInstance() with a null
check, since tcp_con stays 0 when initialize() returns early.
NetTx::~NetTx() gets the same tcp_con null guard as NetRx::~NetRx()
above.
PttPty::~PttPty() guards pty->destroy() with a null
check, since pty stays 0 when initialize() fails before RefCountingPty
is obtained.
Co-Authored-By: Claude Opus 4.8 [email protected]
This PR also adds a unit test (
DtorNullGuardTest.cpp). It is auto-discovered and executed by the CTest suite proposed in #762 once that is merged; without that suite present the test file is inert and does not affect the build.