Fix: Correct error handling pattern for Rust chmod command#8
Open
prjanitor wants to merge 1 commit into
Open
Conversation
…ad of Run followed by CombinedOutput
|
@prjanitor is attempting to deploy a commit to the slashexx's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Description
The chmod command in the Rust case had incorrect error handling. The code called
execCmd.Run()first, then attempted to callexecCmd.CombinedOutput()to retrieve error output. However,CombinedOutput()also executes the command - it cannot be called afterRun()has already executed.Fix
Changed the error handling pattern from:
To:
This correctly uses
CombinedOutput()which both executes the command and captures its output in a single call.Impact
This fix ensures that chmod errors are properly captured and reported when compiling Rust code.
This PR was generated by PRJanitor — an automated tool that finds and fixes small bugs in open-source projects.
We respect your contribution guidelines — if your project doesn't accept bot PRs, we won't send more. You can also add a
.github/prjanitor.ymlfile withenabled: falseto opt out explicitly.