Skip to content

Use append_cflags instead of modifying CLFAGS directly #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ericburns wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use append_cflags instead of modifying CLFAGS directly #525

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ext/extconf.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ def find_file(file, root = nil)
# flag can cause issues for some customers we're turning it off by default. However,
# in development and CI, we still have the option of turning it back on to help catch
# potential issues.
$CFLAGS << " -Werror" if SKYLIGHT_EXT_STRICT
append_cflags(["-Werror"]) if SKYLIGHT_EXT_STRICT

checking_for "fast thread local storage" do
if try_compile("__thread int foo;")
Expand All @@ -238,15 +238,15 @@ def find_file(file, root = nil)
end

# Flag -std=c99 required for older build systems
$CFLAGS << " -std=c99 -Wall -fno-strict-aliasing"
append_cflags(["-std=c99", "-Wall", "-fno-strict-aliasing"])

# Allow stricter checks to be turned on for development or debugging
if SKYLIGHT_EXT_STRICT
$CFLAGS << " -Wextra"
append_cflags(["-Wextra"])

# Enabling unused-parameter causes failures in Ruby 2.6+
# ruby/ruby.h:2186:35: error: unused parameter 'allow_transient'
$CFLAGS << " -Wno-error=unused-parameter"
append_cflags(["-Wno-error=unused-parameter"])
end

# TODO: Compute the relative path to the location
Expand Down