[ENH] Fixes #1051: add hyperactive tuner as importable#1054
Open
Atharv1405 wants to merge 2 commits into
Open
Conversation
fkiraly
requested changes
May 30, 2026
fkiraly
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! This should have the tests:vm tag though so it runs on a VM.
Author
|
Added vm tag . i hope its correct now @fkiraly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #1051
What does this implement/fix? Explain your changes.
This PR implements the dynamic _placeholder_record forwarding pattern in skpro registry (similar to sktime Prophetverse integration) and registers the ProbaRegOptCV hyperactive-tuner wrapper as an importable placeholder class.
Specifically:
Does your contribution introduce a new dependency? If yes, which one?
Yes, it introduces hyperactive as an optional soft dependency. It does not introduce any new hard dependencies
What should a reviewer concentrate their feedback on?
Did you add any tests for the change?
No direct standalone test was added
Any other comments?
PR checklist
For all contributions
How to: add yourself to the all-contributors file in the
skproroot directory (not theCONTRIBUTORS.md). Common badges:code- fixing a bug, or adding code logic.doc- writing or improving documentation or docstrings.bug- reporting or diagnosing a bug (get this pluscodeif you also fixed the bug in the PR).maintenance- CI, test framework, release.See here for full badge reference
For new estimators
docs/source/api_reference/taskname.rst, follow the pattern.Examplessection.python_dependenciestag and ensureddependency isolation, see the estimator dependencies guide.