docs: add senior-sa and senior-sd to research phase orchestration#76
Conversation
- senior-sa and senior-sd existed in .claude/agents/ but were never referenced by agent-team or team-lead, so they were unreachable in the SDD pipeline - SAAgent analyzes business flow from spec.md scenarios; SDAgent designs class/sequence diagrams — scopes annotated to avoid overlap with ArchitectAgent and APIDesignAgent - diagrams are returned as Mermaid text and embedded into plan.md by team-lead during synthesis, keeping research agents read-only and preserving the single-writer pattern Co-Authored-By: Claude Opus 4.7 <[email protected]>
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
There was a problem hiding this comment.
This documentation change correctly integrates senior-sa and senior-sd agents into the Research Phase orchestration. The cross-references to .claude/agents/senior-sa.md and .claude/agents/senior-sd.md are valid, and the changes are consistent across both orchestration files. No defects found that block merge.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces two new research agents, SAAgent (senior-sa) and SDAgent (senior-sd), to generate business flowcharts and UML diagrams in Mermaid format, which are then embedded into plan.md by the Team Lead. The review comments correctly identify a sequencing issue where embedding these diagrams during the synthesis phase (before running /speckit.plan) would cause them to be overwritten when the plan is generated. The feedback suggests updating the instructions to perform the embedding after /speckit.plan has run, which is a necessary correction to prevent data loss.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
…i review) - review found a sequencing error: plan.md is created by /speckit.plan from plan-template, so "embed during synthesis" referenced a file that does not exist yet - corrected flow: SA/SD Mermaid diagrams are synthesized findings that feed into /speckit.plan and land in the template's existing diagram sections — no post-plan embedding pass needed
1 participant
Summary
senior-saandsenior-sdexisted in.claude/agents/but were never referenced by any orchestration file, making them unreachable in the SDD pipeline/speckit.plan): SAAgent analyzes business flow fromspec.mduser scenarios → Mermaid flowchart; SDAgent designs class/sequence diagrams for the planned featureplan.mdby team-lead during synthesis — research agents stay read-only, preserving the single-writer patternChanged Files
.claude/commands/agent-team.md.claude/agents/team-lead.mdTest Plan
.claude/agents/senior-sa.mdand.claude/agents/senior-sd.md; both orchestration files describe the same flow🤖 Generated with Claude Code