chore: add sips as macOS built-in SVG-to-PNG fallback#71
Conversation
- Add sips (macOS built-in) as fourth fallback tool after ImageMagick - All tool paths now also generate icon-colored.png (512px, transparent bg) for GitHub organization profile picture uploads - Regenerate social-preview.png via sips Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
There was a problem hiding this comment.
The implementation correctly adds sips as a macOS built-in fallback for SVG-to-PNG conversion and ensures all tool paths generate icon-colored.png. The changes follow existing code patterns and maintain consistency across all conversion tools. No blocking issues identified.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for the macOS built-in sips tool to convert SVG files to PNG, and introduces the generation of a 512px icon-colored.png asset across all supported tools. However, the reviewer pointed out that sips does not natively support SVG as an input format, which will cause the script to fail at runtime. It is recommended to remove the sips detection and execution blocks entirely.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
sips renders SVG at the native width/height, then resamples. With the previous width="48" height="48", it rendered at 48px and upscaled — causing blurriness. Setting width/height to 512 renders at full resolution; smaller sizes are downscaled, which is always sharper. viewBox is unchanged so the visual geometry is identical. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
…export Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
…son Hyperlegible fonts Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
|
Codex Review: Didn't find any major issues. Hooray! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…nput sips on macOS only accepts raster formats; passing an SVG causes an "unsupported image format" error which exits the script immediately under `set -e`. Removed the sips detection block, its case branch, and updated the header comment and error message accordingly. Co-Authored-By: Claude Haiku 4.5 <[email protected]>
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
Test plan
🤖 Generated with Claude Code
Review Resolutions
Round 1 — 2026-06-09