feat(console): use ids for admin record urls#658
Open
mreq wants to merge 3 commits into
Open
Conversation
Generate console polymorphic member URLs with database IDs while leaving public FriendlyId URLs unchanged. Load site-scoped console records by numeric ID and redirect legacy slug GET URLs to ID URLs.
# Conflicts: # app/controllers/folio/console/base_controller.rb
The legacy FriendlyId -> id console redirect merged raw request query params into url_for options with only_path: false. A query param like ?host=evil.example.com flowed into url_for as the :host option, producing an off-host URL that redirect_to then rejects with UnsafeRedirectError (500) under Rails 8's open-redirect protection; legitimate query params named host/protocol/port/script_name likewise broke URL generation. Generate a same-host path (only_path: true) and re-attach the original query string verbatim, so query params are preserved as query params and can never hijack the redirect target.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate console polymorphic member URLs with database IDs while leaving public FriendlyId URLs unchanged. Load site-scoped console records by numeric ID and redirect legacy slug GET URLs to ID URLs.