Skip to content

SWHC044-08 PY2028 Update - #95

Merged
behzadsalimian merged 22 commits into
SWHC044-08from
dev-SWHC044-08
Jul 23, 2026
Merged

SWHC044-08 PY2028 Update#95
behzadsalimian merged 22 commits into
SWHC044-08from
dev-SWHC044-08

Conversation

@yagi-solaris

@yagi-solaris yagi-solaris commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

SWHC044-08 PY2028 update includes the following:

  • Update weather files to CZ2025.
  • Update cases and cohorts files to templatized prototype.
  • Removed cases based on revised offerings.
  • Update "res-zone-hvac-combi.pxt" to include CCH and defrost parameters.
  • Revised AC baseline efficiency from 11.0 EER to 13.1 EER to align with the new federal minimum as of May 26, 2026.

Main Contributor: Yasemin Agi ([email protected])

DEER Support Email: [email protected]

PR Author

  • Make sure the PR branch is up to date with main branch at the time of the PR submission
  • Craft a succinct title that effectively encapsulates the essence of the pull request, providing a general overview of the proposed changes.
  • Label the PR with at least one of the following: New Measure, Bug, or Feature.
  • Provide a concise description of the measure, bug, or feature. Submit one PR per measure.
  • For a new measure, attach a workbook named DEER_EnergyPlus_Modelkit_Measure_list_working.xlsx, containing only rows used for post-processing the measure.
  • Add comments in the code when necessary to facilitate the review process.
  • Add a comment before the added code, including the author's full name, company, and specifying if it's a bug fix, new measure, or feature.
  • For a new feature or bug, demonstrate the impact on energy consumption for selected cases with justification using plots and descriptions.
  • For a new measure, add a summary table showing total energy consumption per simulated case.

PR Reviewer

  • Conduct a thorough code review.
  • If the branch is behind the main, merge the branch locally to check for potential conflicts.
  • If a bug, locally reproduce it and compare energy consumptions before and after.
  • Explore creative ways to stress-test the code.
  • Locally check the error file and other outputs.

@yagi-solaris
yagi-solaris changed the base branch from main to SWHC044-08 June 22, 2026 21:31

@ncampbell10 ncampbell10 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request reviewed. No comments.

@nfette
nfette requested a review from ncampbell10 July 19, 2026 01:44
@behzadsalimian

behzadsalimian commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

@yagi-solaris, could you remove the rows in the DEER_EnergyPlus_Modelkit_Measure_list_SWHC044.xlsx file that are not related to this measure package?

@behzadsalimian

Copy link
Copy Markdown
Collaborator

@yagi-solaris, if you generate simdata file, locate the query file that you used along with the result2.py here residential measures
/SWHC044-08 Ductless HVAC Fuel Sub and update the README file and add any explanation needed for post-processing/running the simulation.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yagi-solaris, can you add an explanation in the README file on when we should use this file and why this file has been created?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added explanations to README file/addressed all comments.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yagi-solaris, are you using this query file to generate the simdata file? I see you mentioned in the README file that you are using this command: cd C:/.../SWHC044-08 Ductless HVAC Fuel Sub Generate 'simdata.csv' using result2.py and query_default.txt. Is that correct?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually that was not the one I was using for result2.py, that was for result.py. I just corrected to the right query file and updated the README accordingly.

@yagi-solaris

Copy link
Copy Markdown
Collaborator Author

@behzadsalimian All done with discussed changes.

@behzadsalimian

Copy link
Copy Markdown
Collaborator

Yasemin added this bullet point for clarification: Revised AC baseline efficiency from 11.0 EER to 13.1 EER to align with the new federal minimum as of May 26, 2026. She modified the techID name in the case file to have the right EER and updated the cooling COP accordingly.

@behzadsalimian

behzadsalimian commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

I verified that the measure list workbook is aligned with the TechIDs and measure offerings table in eTRM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants