SWCR008-06 PY2028 Update

[kny4]

This is the internal review pull request for SWCR008 update to CZ2025 weather (PY2028) and includes the following items.

• Add ver06 folder
• Update weather files to 2025

PR Author QC Checklist

• Confirm that condenser sizing parameters were added in main branch
• Confirm this measure setup uses condenser sizing values consistent with SWCR007 and Solaris' analysis

PR Author

• Make sure the PR branch is up to date with main branch at the time of the PR submission
• Craft a succinct title that effectively encapsulates the essence of the pull request, providing a general overview of the proposed changes.
• Provide a concise description of the measure, bug, or feature. Submit one PR per measure.
• For a new measure, attach a workbook named DEER_EnergyPlus_Modelkit_Measure_list_working.xlsx, containing only rows used for post-processing the measure.
• Add comments in the code when necessary to facilitate the review process.
• Add a comment before the added code, including the author's full name, company, and specifying if it's a bug fix, new measure, or feature.

PR Reviewer

• Conduct a thorough code review.
• If the branch is behind the main, merge the branch locally to check for potential conflicts.

[kny4]

Commit comment should say "updated query.txt file to successfully run Com.py"

The original query.txt file is the query_default.txt from the querylibrary. However, due to missing results-summary.csv columns generated by this file, Com.py would not run. Since I recently ran Com.py for #SWCR003-05, I compared the 2 query.txt files found within the measure-vintage subfolder and saw that SWCR003 had the missing columns included in its query.txt. I found the same "updated" query.txt file in other commercial measure-vintage subfolders included in the main branch (i.e. SWHC013-8, SWHC014-8, SWHC018-05, SWHC024-06, SWHC027-08, etc).

It appears that the query.txt was updated to align with Com.py but the file was not added/updated in the querylibrary.

[kny4]

I'm not sure what purpose the "Wrf" building type cases serves, but it was copied as is from the previous measure version. Would suggest removing it if unneeded.

[kny4]

This is the comparison between the query.txt (same as querylibrary\query_default.txt) and query.txt found in other measure subfolders.

[kny4]

Commit comment should say "updated query.txt file to successfully run Com.py"

The original query.txt file is the query_default.txt from the querylibrary. However, due to missing results-summary.csv columns generated by this file, Com.py would not run. Since I recently ran Com.py for #SWCR003-05, I compared the 2 query.txt files found within the measure-vintage subfolder and saw that SWCR003 had the missing columns included in its query.txt. I found the same "updated" query.txt file in other commercial measure-vintage subfolders included in the main branch (i.e. SWHC013-8, SWHC014-8, SWHC018-05, SWHC024-06, SWHC027-08, etc).

It appears that the query.txt was updated to align with Com.py but the file was not added/updated in the querylibrary.

Com.py needs to use this query file for the results-annual.csv: commercial measures\SWXX000-00 Measure Name\SWXX000-00 Measure Name_Ex\query.txt. This is the same file used in the other commercial measures.

[behzadsalimian]

@kny4 Remove this file, since it is no longer applicable to this version.

[kny4]

Removed file

[behzadsalimian]

@kny4 Make sure that the README file is up to date. If not, please update it.
Also, if you could add some explanation about how you did post-processing and got the results, that would be helpful. You could take a look at the readme file for SWHC049/050/027 as a reference.

[kny4]

Updated README

[behzadsalimian]

@kny4 If WRf is not applicable for this measure package, remove it from the cases file.

[kny4]

Removed

[behzadsalimian]

@kny4 Please add the measure list workbook that you used for post-processing under the measure folder setup.

[behzadsalimian]

@kny4 Please review the checklist at the top two items added by Nick, and if you verify the items, please check the boxes.

[kny4]

@kny4 Please review the checklist at the top two items added by Nick, and if you verify the items, please check the boxes.

Items have been completed.

[kny4]

@kny4 Please add the measure list workbook that you used for post-processing under the measure folder setup.

Added measure list workbook

[behzadsalimian]

@kny4 Please review the checklist at the top two items added by Nick, and if you verify the items, please check the boxes.

Items have been completed.

@kny4 Based on Nick's review, we did not capture the correct condenser sizing for air-cooled condensers. Here are the case parameters from SWCR007:

Here are the cases parameters in the new SWCR008 pull request:

Could you take a look at the case files on your laptop and see what condenser sizing has been used? If they are not aligned with the SWCR007 case parameters, you should correct the case files for SWCR008, commit the changes, re-run the simulation, and update the results accordingly.

[kny4]

@kny4 Please review the checklist at the top two items added by Nick, and if you verify the items, please check the boxes.

Items have been completed.

@kny4 Based on Nick's review, we did not capture the correct condenser sizing for air-cooled condensers. Here are the case parameters from SWCR007:

Here are the cases parameters in the new SWCR008 pull request:

Could you take a look at the case files on your laptop and see what condenser sizing has been used? If they are not aligned with the SWCR007 case parameters, you should correct the case files for SWCR008, commit the changes, re-run the simulation, and update the results accordingly.

I've added the condenser sizing to align with SWCR007