feat(dna): complete K1 triangulation clustering (ICW + Leeds labels) - #23
Draft
simonellefsen wants to merge 4 commits into
Draft
feat(dna): complete K1 triangulation clustering (ICW + Leeds labels)#23simonellefsen wants to merge 4 commits into
simonellefsen wants to merge 4 commits into
Conversation
Split mixed maternal/paternal path clusters, name groups by four-grandparent Leeds slots with MRCA fallback, and document the clustering model in wiki/sources/dna-triangulation.md. Co-authored-by: Cursor <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Use path topology and computeRelationship instead of falling back to the path endpoint when edge labels are missing or mis-oriented. Co-authored-by: Cursor <[email protected]>
Shared-segment CSV imports launched from a person's DNA tab now lock the counterpart to that profile (the CSV match links to them), while the autosomal tester/owner is picked or suggested independently - fixing cases where the tester differs from the profile (e.g. a parent's kit run on behalf of the profile person). - SharedSegmentImportModal: add profilePersonId/profileDisplayName props, lock counterpart selection, resolve owner display name against autosomal testers instead of all tree people. - DNATab: pass profile context into both single and batch import modals; drop the now-redundant SharedAutosomalPartyLine match row; drop the now-unused loadingTreePeople read (setter still used). - dnaSharedImportOwner: suggestKitOwnerPersonId no longer falls back to the profile person as owner when they aren't an autosomal tester; added regression test. - Document 2026-07-06 screenshot-sweep findings (K14-K17, L8, M13, O2-O3, Q1, V5, Y3, Z1-Z5) in TODO.md and wiki/roadmap.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
splitClustersByParentalSide).buildLeedsClusterLabels) and wires both into the admin DNA panel.wiki/sources/dna-triangulation.mdand marks K1 done inTODO.md/wiki/roadmap.md.Test plan
npm test(462 passing locally at push time)npm run lint && npm run typecheckMade with Cursor