Save state of the sidebar & dynamic canvas resize#5
Open
Malasuerte94 wants to merge 15 commits into
Open
Conversation
…cy in lgs::config
The list and helper were duplicated across desktop/commands.rs, lgs/devtool.rs
and (newly in this branch) lgs/session.rs — three copies that already had
drifted between unwrap_or("USD") and unwrap_or(config::CURRENCY). Expose them
from lgs::config and have every caller use the shared version.
…and display on page
…-dev-tool into feat-sessions Merge
False positive
…and display on page
…cy in lgs::config
The list and helper were duplicated across desktop/commands.rs, lgs/devtool.rs
and (newly in this branch) lgs/session.rs — three copies that already had
drifted between unwrap_or("USD") and unwrap_or(config::CURRENCY). Expose them
from lgs::config and have every caller use the shared version.
…-dev-tool into feat-sessions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Local storage of the state of the sidebar closed and opened, dynamic resolution change for the viewport on the main desktop view so we can test dynamic canvas resize affecting the game
Why
We encountered problems in our games because we did not tested how games behaves when we change the canvas size like stake does.
Screenshots / recordings
Breaking changes?
Nope