Fixed CI build to work with latest version of VS#268
Merged
Conversation
Changed builds and installers to get CHM file directly from the submodule instead of copying it to Distfiles.
… file via a submodule. Also changed GHA CI build to make an (unsigned) installer for PR builds Updated copyright date and removed obsolete information about JetBrains
andrew-polk
reviewed
Jun 24, 2026
andrew-polk
left a comment
andrew-polk
left a comment
Contributor
There was a problem hiding this comment.
Worth looking at devin's comments about missing file error handling.
https://app.devin.ai/review/sillsdev/saymore/pull/268
@andrew-polk reviewed 9 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on tombogle).
… properly report unexpected problems with help file
Collaborator
Author
|
Good catch on Devin's part. It actually crashed 100% of the time in Dev! |
andrew-polk
approved these changes
Jun 24, 2026
andrew-polk
left a comment
andrew-polk
left a comment
Contributor
There was a problem hiding this comment.
@andrew-polk reviewed 2 files and all commit messages.
Reviewable status:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed builds and installers to get CHM file directly from the submodule instead of copying it to Distfiles.
This change is