L10n and i18n improvements#266
Conversation
Fixed output of progress messages during archiving. Refactor ComponentRole.Name to use a Func<string> delegate for live localization Replace the stored _englishLabel string with a Func<string> _nameProvider delegate so that Name re-evaluates on every access, picking up locale changes at runtime. Production call sites wrap LocalizationManager.GetString in a lambda; test sites use simple () => "label" lambdas. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Additional fixes to progress messages during archiving. Fixed English typos and punctuation issues. Updated localizations. Lots of corrections to the Portuguese!
Removed VC.Tools.x86.x64 component from installer setup.
… l10n-and-i18n-improvements
andrew-polk
left a comment
andrew-polk
left a comment
There was a problem hiding this comment.
Devin has a bug report.
Also worth reading through the other flags if you haven't.
@andrew-polk reviewed 26 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on tombogle).
|
I started to "fix" the bug, but upon further analysis, I decided to leave it. The progress message reports the actual "name" of the special session, and it's not clear that it would be good to report a localized name in its place. Additionally, changing the name under which it is archived has the potential downside of making the archive less usable, since the preferred language of the user might have nothing to do with the language of the project or the language of the person(s) wanting to access the archive. At least if it stays in English, it maximizes the possibility of being "portable" and of a future researcher being able to understand it and/otr obtain a translation into some other language. |
andrew-polk
left a comment
andrew-polk
left a comment
There was a problem hiding this comment.
@andrew-polk reviewed 6 files and all commit messages.
Reviewable status:
2 participants
This change is