fix(live-preview): skip stackblitz source fetch when no example is set#2248
Merged
Merged
Conversation
The stackblitz button's httpResource built a request URL unconditionally, resulting in a 404 GET for app/examples/undefined.ts when no example was selected (e.g. the default viewer/editor route). Return undefined from the request factory when no example is set so the resource stays idle.
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the SiStackblitzButtonDirective to conditionally fetch the TypeScript example file only when the example is defined, preventing unnecessary HTTP requests when the example value is falsy. I have no feedback to provide as there are no review comments.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
spliffone
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Navigating to the live-preview app root (
localhost:4200, which redirects toviewer/editor) produced a runtime console error:Cause
The stackblitz button directive's
httpResourcebuilt its request URL unconditionally:When no example was selected,
example()isundefined, so the resource fetchedapp/examples/undefined.ts, returning a 404.Fix
Return
undefinedfrom the request factory when no example is set, which keeps thehttpResourceidle so no request is made until a real example is selected.The button remains disabled when there is no example (already handled by
!this.example()in thedisabledcomputed).Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: