Conversation
In the cross-compilers CI tests, update the configuration of the initial non-cross compiler to set the same options than in standard opam packages (`ocaml-variants.opam` or the released `ocaml-compiler` packages)
The `HOST_LIBDIR` variable was used only internally in `Makefile.common` so that `Makefile.cross` could override it. But when a cross compiler is configured, even with `--with-relative-libdir`, the resulting value was absolute because `LIBDIR` is then the concatenation of the binary directory with the relative libdir path. This introduces a matching `host_libdir` variable in `configure` to store the relative path when it is set and so that `HOST_LIBDIR` contains the expected value in cross and non-cross cases. This also allows to set both `--with-relative-libdir` and `TARGET_LIBDIR` explicitly when building a cross compiler, where the relative libdir is meant for the host.
Set the `configure`-internal `default_separator` variable according to host instead of target and rename it `host_dir_sep` to make this more explicit This makes the `--with-relative-libdir` option choose the proper path and the test that the path is explicit relative consistent (but it doesn't fix the fact that some paths are currently shared between host and target) Note that the change is transparent when host = target
When configuring a cross compiler with `./configure --with-relative-libdir TARGET_LIBDIR=...` use `TARGET_LIBDIR` instead of the host libdir to set `target_libdir_is_relative`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.