Add iceberg theme - #244
Merged
Merged
Conversation
Port of cocopon/iceberg.vim with both dark and light variants. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new built-in Iceberg theme (dark + light variants) to Textbringer by porting the palette and face mappings from cocopon/iceberg.vim.
Changes:
- Introduce
icebergtheme definition with separate:darkand:lightpalettes. - Define programming/UI/completion/dired faces for the theme and set default foreground/background colors.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| p.color :green, hex: "#668e3d", ansi: "green" # PreProc/Special guifg | ||
| p.color :purple, hex: "#7759b4", ansi: "magenta" # Constant guifg | ||
| p.color :orange, hex: "#eac6ad", ansi: "yellow" # Search guibg | ||
| p.color :search_fg, hex: "#85512c", ansi: "yellow" # Search guifg |
There was a problem hiding this comment.
In the light palette, both :orange and :search_fg resolve to the same ANSI color ("yellow"). When the terminal is in ANSI tier (<256 colors), :isearch will end up with yellow foreground on yellow background, making matches unreadable. Consider changing the ANSI mapping for either :search_fg (e.g., to "black"/"brightblack") or :orange so that :isearch always has sufficient contrast in ANSI tier.
Suggested change
| p.color :search_fg, hex: "#85512c", ansi: "yellow" # Search guifg | |
| p.color :search_fg, hex: "#85512c", ansi: "black" # Search guifg |
Change search_fg ansi from "yellow" to "black" in the light palette to avoid same-color foreground/background in ANSI tier. Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of cocopon/iceberg.vim with both dark and light variants.