Classify getUserMedia failures instead of always reporting denial#156
Merged
Conversation
The recorder caught every getUserMedia rejection and showed 'Microphone access was denied', so a busy device (NotReadableError, e.g. another app or the companion holding the mic) or a missing one (NotFoundError) read as a permission problem the user could not fix. Classify by DOMException name and give an actionable message per case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The in-meeting recorder caught every getUserMedia rejection and displayed "Microphone access was denied", so a device held by another app (NotReadableError, e.g. Zoom or the Minutia companion) or a missing device (NotFoundError) was reported as a permission problem the user could not resolve. Live testing hit exactly this: the message persisted after mic access was granted. New pure
micErrorMessagemaps the DOMException name to an actionable message (denied / in use / not found / generic), with contract tests in verify-audio-capture.