Php 7#5
Open
jpauli wants to merge 2 commits into
Open
Conversation
Owner
|
Thanks for the PR - looks like travis CI builds are failing with this one though, build does not complete and tests do not run. Any idea why? |
Author
|
No. Tests pass to me, except test 14 probably due to some platform details in libvktor |
Owner
|
What system / which PHP versions are you testing on (except for 7)? |
Author
|
I use Debian64 and tested mainly with 5.6 and 7.0 |
Author
|
I managed to fix the last failing test, and now all pass to me for PHP 7 |
ProdigyView
approved these changes
Nov 30, 2018
|
Just installed his branch, it works up to PHP 7.2 |
Owner
|
Hi,
Unfortunately I no longer have the capacity / knowledge to maintain this
extension.
I would be more than happy if someone decides to maintain a new fork, would
endorse / direct users to a new fork if you wish to create one.
Cheers.
…On Sat, Dec 1, 2018 at 1:15 AM Devin Dixon ***@***.***> wrote:
Just installed his branch, it works up to PHP 7.2
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#5 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEAG8sBJgAg94KIIpKDGajyP040a508ks5u0bwtgaJpZM4GbBeB>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 7 branch