fix(auth): remove duplicate byline, keep single Shema attribution - #19
Merged
Conversation
The existing authHero.byline footer ("by Shemá · YWAM Kansas City")
and the new attribution line were rendering stacked under the login
card. Drops the old footer so a single canonical line remains:
by Shema Bible Translation · YWAM Kansas City
Bumps the attribution marginTop from 12 to 24 so its spacing matches
what the old footer used. The authHero.byline i18n key is now unused
but left in the locale files for now.
Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
authHero.bylinefooter ("by Shemá · YWAM Kansas City") from the AuthShell login screen.marginTopfrom 12 → 24 so it inherits the spacing the old footer used.authHero.bylinei18n key is now unused but left in locale files (cleanup deferred).Test plan
npm run devand open/loginby Shema Bible Translation · YWAM Kansas City🤖 Generated with Claude Code