Skip to content

Add check to disable validate_records, add support unsigned number using minLength #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Viet Vu (vietvudanh) wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Add check to disable validate_records, add support unsigned number using minLength #170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
caa613e
add check to disable validate_records
vietvudanh Jun 20, 2024
50f132d
add support for unsigned int based on minLength
vietvudanh Jun 25, 2024
9deee84
change block code to call parent's `super()._validate_and_parse(record)`
vietvudanh Jun 25, 2024
a8c66d9
fix wrong key name
vietvudanh Jun 25, 2024
8125f67
the value is 0, need to specify the check!
vietvudanh Jun 26, 2024
7f0d99e
Merge remote-tracking branch 'original_repo'
vietvudanh Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions target_clickhouse/connectors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,10 +105,15 @@ def to_sql_type(
sqlalchemy.types.FLOAT(),
)
elif type(sql_type) == sqlalchemy.types.INTEGER:
sql_type = typing.cast(
sqlalchemy.types.TypeEngine,
clickhouse_sqlalchemy_types.Int64(),
)
minimum = jsonschema_type.get("minimum")
if minimum is not None and minimum == 0:
sql_type = typing.cast(
sqlalchemy.types.TypeEngine, clickhouse_sqlalchemy_types.UInt64(),
)
else:
sql_type = typing.cast(
sqlalchemy.types.TypeEngine, clickhouse_sqlalchemy_types.Int64(),
)
elif type(sql_type) == sqlalchemy.types.DATE:
sql_type = typing.cast(
sqlalchemy.types.TypeEngine,
Expand Down
14 changes: 1 addition & 13 deletions target_clickhouse/sinks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,19 +162,7 @@ def _validate_and_parse(self, record: dict) -> dict:
# Pre-validate and correct string type mismatches.
record = pre_validate_for_string_type(record, self.schema, self.logger)

try:
self._validator.validate(record)
self._parse_timestamps_in_record(
record=record,
schema=self.schema,
treatment=self.datetime_error_treatment,
)
except jsonschema_exceptions.ValidationError as e:
if self.logger:
self.logger.exception(f"Record failed validation: {record}")
raise e # : RERAISES

return record
return super()._validate_and_parse(record)

def _parse_timestamps_in_record(
self,
Expand Down