fix(cli): fix BUILTIN_MODULES Set syntax and add builtin module filtering - #11566
Open
waterWang wants to merge 1 commit into
Open
fix(cli): fix BUILTIN_MODULES Set syntax and add builtin module filtering#11566waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
…ring - Fix BUILTIN_MODULES Set definition: remove outer array brackets that caused the Set to contain a single array element instead of individual strings, making BUILTIN_MODULES.has() always return false. - Add BUILTIN_MODULES check in getDependencyFromModuleSpecifier to prevent Node.js built-in modules from being added as npm dependencies in package.json. Closes shadcn-ui#11565
Contributor
|
@waterWang is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Can you sign the commits please? See https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11565
Changes
1. Fix BUILTIN_MODULES Set syntax (constants.ts)
The Set was defined with an extra outer array wrapper (
new Set([[...]])), causing the Set to contain a single array element instead of individual strings. This madeBUILTIN_MODULES.has()always returnfalse.2. Add builtin module filtering (utils.ts)
getDependencyFromModuleSpecifiernow checksBUILTIN_MODULESbefore processing. Bare Node.js imports likepath,fs/promises,cryptoare no longer incorrectly added as npm dependencies inpackage.json.